[Kde-pim] Review Request: Support multiple default selections in CollectionDialog

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103320/#review10454
-----------------------------------------------------------

Ship it!


Looks good to me, sorry for taking so long to review this.

- Volker Krause


On Dec. 3, 2011, 9:08 p.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103320/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 9:08 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Add support to CollectionDialog for adding multiple default selections, needed for https://git.reviewboard.kde.org/r/103318/.
> 
> Note that the model given to the AsyncSelectionHandler was changed; this was necessary because one of the QSortFilterProxyModels was complaining about being given a QMI from a different model in MapToSource, so I suspect that the default selection support for single selections is broken too.
> 
> 
> Diffs
> -----
> 
>   akonadi/asyncselectionhandler.cpp fe40521 
>   akonadi/asyncselectionhandler_p.h 3fd8fb8 
>   akonadi/collectiondialog.h d7e7079 
>   akonadi/collectiondialog_desktop.cpp 1934689 
> 
> Diff: http://git.reviewboard.kde.org/r/103320/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will Stephenson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/