[Kde-pim] Review Request: Fixed item existance check in the Nepomuk feeder

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103980/#review10695
-----------------------------------------------------------


This review has been submitted with commit 7a5f79d5e97a5039c84d8251bf8acd387504b704 by Sebastian Trueg to branch master.

- Commit Hook


On Feb. 14, 2012, 2:03 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103980/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 2:03 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> The Nepomuk feeder contains a check to see if a certain item exists. This check uses
>   containsAnyStatement( Soprano::Node(), ANEO::akonadiItemId(), Soprano::LiteralValue( QUrl( QString::number( item.id() ) ) ) )
> This will result in an invalid LiteralValue since the latter does not handle URLs. This in turn means that the check will always return true if there is at least one statement with property ANEO::akonadiItemId() in the database.
> 
> This patch fixes it by using a string rather than a QUrl.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/feederqueue.cpp 9274daf 
> 
> Diff: http://git.reviewboard.kde.org/r/103980/diff/
> 
> 
> Testing
> -------
> 
> No testing done yet.
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/