[Kde-pim] Review Request: Refactoring handling IMAP responses during login phase in Akonadi

[Oleg Girko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103854/
-----------------------------------------------------------

(Updated Feb. 13, 2012, 4:40 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Added a note about testing with GMail IMAP server and LOGIN authentication.


Description
-------

Refactoring KIMAP::LoginJob::handleResponse() method in kimap/loginjob.cpp file to make its logic more readable, straightforward and correct.
As a side effect, it fixes https://bugs.kde.org/show_bug.cgi?id=249992 by handling untagged CAPABILITY responses more correct and uniform way.

This change is trivially backportable to KDE 4.7 (tested with KDE 4.7.4).


This addresses bug 249992.
    http://bugs.kde.org/show_bug.cgi?id=249992


Diffs
-----

  kimap/loginjob.cpp fad276d957e46fd00efa20a5f235d02a639ab2c4 

Diff: http://git.reviewboard.kde.org/r/103854/diff/


Testing (updated)
-------

Successfully tested with Dovecot IMAP server 2.0.17 using CRAM-MD5 and GSSAPI authentication with unencrypted and SSL connection. Also tested with GMail's own IMAP server using SSL connection and LOGIN authentication.


Thanks,

Oleg Girko

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/