[Kde-pim] Hunting down #291171 and other filtering issues

[Andras Mantia]

Szymon Tomasz Stefanek wrote:

> On Saturday 25 February 2012 11:23:07 Andras Mantia wrote:
> 
>> > 1) Fix the filtering bug only: remove all the parse() calls from the
>> > filters as Akonadi seems to call parse() itself at the moment the
>> > message is fetched. KMime never tries to parse an empty body and it
>> > never updates the Content- Type header... maybe.
>> 
>> Due to above this sounds like a sane approach.
> 
> OK. I'll try it.
> 
> Hm.. there may be some code paths that take input from a source that
> doesn't actually call parse() on the message...
> 
> What about adding an "ensureParsed()" method to KMime::Content that
> calls parse() only if it hasn't been called with the current contents yet
> ?
> 
> Then I could just convert every call to parse() into ensureParsed()...
> 
> (...and maybe then we could also deprecate parse() ?).


Sounds ok for me, but wait for other's opinion as well (Ingo, Thomas 
McGuire, Tobias Koenig for example). And of course, post a review request 
for it (separately for KMime and for the filtering agent).

Andras
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/