[Kde-pim] Review Request: Add sqlite support to akonadi kcm

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103894/#review10443
-----------------------------------------------------------


Technically this looks correct. There is a fundamental problem with the backend selection in this dialog though. Akonadi does not really support runtime switching of the backend, so changing the setting is equivalent to deleting your database, there is no migration code. But IIRC that KCM is not available for normal users anyway, so that's probably fine, a warning couldn't hurt though.

Anyway, that problem exists already, even without your patch, so I'm not objecting to adding this.

- Volker Krause


On Feb. 8, 2012, 3:24 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103894/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2012, 3:24 p.m.)
> 
> 
> Review request for KDEPIM and Radek Novacek.
> 
> 
> Description
> -------
> 
> Fairly simple patch, adds sqlite support to akonadi kcm.
> 
> 
> Diffs
> -----
> 
>   kcm/serverconfigmodule.h 1a50c63 
>   kcm/serverconfigmodule.cpp 930b6c8 
> 
> Diff: http://git.reviewboard.kde.org/r/103894/diff/diff
> 
> 
> Testing
> -------
> 
> Fedora 16 shipped with this, though strictly speaking only tested against kdepim-runtime-4.7.x and 4.8.0 so far (not master/)
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/