[Kde-pim] Review Request: Fixed configuration GUI for the Nepomuk Akonadi feeder

[Sebastian Trueg]

> On Feb. 14, 2012, 5:17 p.m., Volker Krause wrote:
> > nepomuk/kcm/nepomukserverkcm.cpp, line 258
> > <http://git.reviewboard.kde.org/r/103982/diff/1/?file=49490#file49490line258>
> >
> >     I fixed this part last weekend on the kdepim side, changing it here would break it again.
> 
> Sebastian Trueg wrote:
>     How did you fix that? Did you add per-plugin disabling to the feeder?
> 
> Christian Mollekopf wrote:
>     He just changed the KConfigGroup identifier to read the settings in the nepomukfeeder.

I did not find that in the master of 4.8 branched. Also it seems like a very ugly fix in the wrong place. Why would the akonadi_nepomuk_feeder read its settings from akonadi_nepomuk_email_feederrc? Or did I misunderstand?
In any case I think this is the place to fix it.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103982/#review10634
-----------------------------------------------------------


On Feb. 14, 2012, 2:49 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103982/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 2:49 p.m.)
> 
> 
> Review request for KDEPIM, Volker Krause and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Ever since KDE 4.8 there is no email_feeder agent anymore. All is handled by one feeder now which has different plugins. These plugins cannot be disabled separately yet. Thus, the only way to do it is to disable the whole indexer. This will not actually disable all indexing - but that is another story.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/nepomukserverkcm.cpp 1ccc405 
> 
> Diff: http://git.reviewboard.kde.org/r/103982/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/