[Kde-pim] Review Request: Add 'Save Attachments' menus to kmail

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103963/#review10602
-----------------------------------------------------------


Why add new entry ?
We already this entry when we right click on mail (in messageviewer).
I don't think it's a good idea to add an other menu entry in menu "Message" in menu right click on messagelist.

I think that kmail has a lot of menu entry. Perhaps it's not necessary to add more entry for an action that we have on right click.

- Laurent Montel


On Feb. 13, 2012, 10:33 a.m., Peter Pille wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103963/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 10:33 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch adds menu entries to kmail for conveniently saving the attachments of an email
> 
> 
> Diffs
> -----
> 
>   kmail/kmail_part.rc e3e6bd2df3349dd9f598aee3f7f67208c5dbe4f2 
>   kmail/kmmainwin.rc e3e6bd2df3349dd9f598aee3f7f67208c5dbe4f2 
>   kmail/kmreadermainwin.cpp a885c0d81a482118f962d3c6bfceec55f8109810 
>   kmail/kmreadermainwin.rc 5c47224b0773f577dfe1f1b0c14e8e2ef40d1139 
>   kmail/messageactions.h 307d1b6e8b1678ea91dfab36b1759d8ca507ecc0 
>   kmail/messageactions.cpp 4311b4054aec9a339d3ea2c92561ac1cd84d9666 
> 
> Diff: http://git.reviewboard.kde.org/r/103963/diff/
> 
> 
> Testing
> -------
> 
> I tested and use this patch on kdepim version 4.7.4 on OpenSuse11.4
> 
> 
> Screenshots
> -----------
> 
> email-contextmenu
>   http://git.reviewboard.kde.org/r/103963/s/431/
> email-kontact messagemenu
>   http://git.reviewboard.kde.org/r/103963/s/432/
> kmail-message-menu
>   http://git.reviewboard.kde.org/r/103963/s/433/
> 
> 
> Thanks,
> 
> Peter Pille
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/