[Kde-pim] Review Request: Fix library API documentation errors

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107723/#review23468
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/107723/#comment18046>

    I don't think you want to commit those :)



akonadi/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107723/#comment18047>

    same here



akonadi/agentactionmanager.h
<http://git.reviewboard.kde.org/r/107723/#comment18048>

    move those so that @since is the last entry



akonadi/agentactionmanager.h
<http://git.reviewboard.kde.org/r/107723/#comment18049>

    remove type here and in the description of text



akonadi/agentbase.h
<http://git.reviewboard.kde.org/r/107723/#comment18050>

    good but lets make that even better
    @param needsNetwork @c true if the agents needs network. Defaults to @c false



akonadi/agentfilterproxymodel.h
<http://git.reviewboard.kde.org/r/107723/#comment18051>

    @param capability undesired agent capability



akonadi/changerecorder.h
<http://git.reviewboard.kde.org/r/107723/#comment18052>

    @param enable @c false to disable change recording. @c true by default



akonadi/collectionfetchjob.h
<http://git.reviewboard.kde.org/r/107723/#comment18053>

    @param include whether to alsof fetch unsubscribed collections



akonadi/collectionfetchjob.h
<http://git.reviewboard.kde.org/r/107723/#comment18054>

    @param include whether to also fetch statistics



akonadi/collectionmodel.h
<http://git.reviewboard.kde.org/r/107723/#comment18055>

    @pram enable whether to fetch collecton statistics



akonadi/specialcollectionshelperjobs_p.h
<http://git.reviewboard.kde.org/r/107723/#comment18056>

    @param type collection type


- Kevin Krammer


On Dec. 14, 2012, 3:46 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107723/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 3:46 p.m.)
> 
> 
> Review request for Akonadi, KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> The review request according to this GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8019228
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0aea59c 
>   akonadi/CMakeLists.txt b5542d0 
>   akonadi/actionstatemanager_p.h 9a7106e 
>   akonadi/agentactionmanager.h 39f7a27 
>   akonadi/agentbase.h fa93eba 
>   akonadi/agentfilterproxymodel.h 2db8946 
>   akonadi/agentinstance.h 085c409 
>   akonadi/agentmanager.h 98698d6 
>   akonadi/agenttype.h b104f23 
>   akonadi/cachepolicy.h 0494963 
>   akonadi/changerecorder.h 8c29a02 
>   akonadi/collectionfetchjob.h 50d8c02 
>   akonadi/collectionmodel.h de22ac2 
>   akonadi/collectionpropertiesdialog.h f6fc071 
>   akonadi/collectionrequester.h ebb877f 
>   akonadi/collectionstatisticsdelegate.h 858a19b 
>   akonadi/collectionstatisticsmodel.h a368c98 
>   akonadi/contact/abstractcontacteditorwidget_p.h b7cfab9 
>   akonadi/contact/abstractcontactformatter.h 44dc5bc 
>   akonadi/contact/abstractcontactgroupformatter.h 46daeaa 
>   akonadi/contact/collectionfiltermodel_p.h 0579180 
>   akonadi/contact/contacteditor.h a43bbe8 
>   akonadi/contact/editor/addresseditwidget.h 033ec46 
>   akonadi/contact/editor/kdatepickerpopup_p.h 9cdd804 
>   akonadi/contact/editor/nameeditwidget.h 2dd4da8 
>   akonadi/contact/waitingoverlay_p.h ce6af5d 
>   akonadi/kmime/addressattribute.h 0f855ed 
>   akonadi/specialcollectionshelperjobs_p.h e8c413a 
> 
> Diff: http://git.reviewboard.kde.org/r/107723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/