[Kde-pim] Review Request: Notify parent collection as well as all virtual collections when item changes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107722/#review23809
-----------------------------------------------------------


This review has been submitted with commit f5256ef459dbf2725932dd845dd073335cc03d9a by Dan Vrátil to branch master.

- Commit Hook


On Dec. 16, 2012, 7:19 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107722/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 7:19 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> When an PimItem is changed, only it's real parent collections is notified. This patch changes behaviour of NotificationCollector to notify the parent collections as well as all virtual collections the item is linked to. AFAIK we don't need to handle removing or adding of item, because the VC is notified through Link/Unlink operation.
> 
> As a result, when you mark an unread email in "Last Search" folder as read, the "Unread" count is updated in item's parent collection and in the "Last Search" folder too (works only with patch from http://git.reviewboard.kde.org/r/107715/). It works the other way around too (i.e. marking an item as read in it's parent collection updates the parent collections an "Last Search" Unread count).
> 
> 
> Diffs
> -----
> 
>   server/src/storage/datastore.h 3bd9676 
>   server/src/storage/datastore.cpp 7615b81 
>   server/src/storage/notificationcollector.cpp 72d3243 
> 
> Diff: http://git.reviewboard.kde.org/r/107722/diff/
> 
> 
> Testing
> -------
> 
> Had an unread email from inbox in "Last Search" results, marked it as read in inbox, "Unread" count updated in both inbox and "Last Search" folders.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/