[Kde-pim] Review Request: MessageViewer: fix warnings about overloaded virtuals being hidden

[Kevin Krammer]

> On Dec. 29, 2012, 5:33 p.m., Allen Winter wrote:
> > looks fine.  I do see a little bit of extra, unneeded whitespace in your patch.  but otherwise commit at will

drat, I'll fix those stray whitespaces before committing.
will commit tomorrow unless Laurent objects
thanks for reviewing


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108001/#review24194
-----------------------------------------------------------


On Dec. 29, 2012, 12:54 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108001/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 12:54 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> When building messageviewer and related plugins, the compiler warns about virtual methods defined in base classes or interface as being hidden by the subclasses.
> In the BodyFormatter cases it should be harmless since the hidden overload just delegates to the reimplemented one.
> In the accessibility case it seems to be a two functions from different interface being considered overloads. One is from QAccessible v1 and one is from QAccessible v2. might be necessary to check whether the v1 one can be removed
> 
> 
> Diffs
> -----
> 
>   messageviewer/a11y/accessiblemailwebview.h 5558551 
>   messageviewer/bodypartformatter.cpp 45ba488 
>   plugins/messageviewer/bodypartformatter/application_ms-tnef.cpp 263f467 
>   plugins/messageviewer/bodypartformatter/text_xdiff.cpp 4660668 
> 
> Diff: http://git.reviewboard.kde.org/r/108001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Krammer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/