[Kde-pim] Review Request: Fix initialization of PostgreSQL db

[Dan Vrátil]

> On Dec. 18, 2012, 7:34 a.m., Andras Mantia wrote:
> > server/src/storage/akonadidb.xml, line 100
> > <http://git.reviewboard.kde.org/r/107776/diff/1/?file=99904#file99904line100>
> >
> >     You should know that "true" is not valid for boolean in SQLite. So this cannot be fixed at this level, instead it should be fixed in code, where the value is translated either to true or 1.

The DbInitializerSqlite class handles conversion from "true" to "1" and "false" to "0". However there is no "true"=>"1" conversion in the DBInitializePostgreSQL class, therefore it was failing (which makes sense, since true/false is more boolean-ish than 1/0).


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107776/#review23652
-----------------------------------------------------------


On Dec. 17, 2012, 9:50 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107776/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2012, 9:50 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Apparently PostgreSQL does not like '1' in a boolean column, so I replaced it by 'true'.
> 
> 
> This addresses bug 311185.
>     http://bugs.kde.org/show_bug.cgi?id=311185
> 
> 
> Diffs
> -----
> 
>   server/src/storage/akonadidb.xml d767c81 
> 
> Diff: http://git.reviewboard.kde.org/r/107776/diff/
> 
> 
> Testing
> -------
> 
> All three backends initialize db succesfully.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/