[Kde-pim] Review Request: Fix for sending mails to untrusted recipients

[Torsten Grote]

> On Dec. 27, 2012, 7:05 a.m., Laurent Montel wrote:
> > messagecomposer/encryptjob.cpp, line 183
> > <http://git.reviewboard.kde.org/r/107847/diff/2/?file=100628#file100628line183>
> >
> >     you change bool alwaysTrust value to true direcly.
> >     Why you can be sure that we can always trust it ?

As I wrote in the description, the first thing that comes up when trying to send an encrypted email to untrusted recipients is a trust dialog that is warning about untrusted keys. If you cancel this, no email will be send.

If you pass alwaysTust as "false" later to Kleo::EncryptJob, the encryption will fail and the message can not be send at all, even if you confirmed that you want to send to untrusted senders already. Since the call to Kleo::EncryptJob is only made when you confirmed all untrusted recipients, I consider this safe.

Does this make sense?


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107847/#review24019
-----------------------------------------------------------


On Dec. 22, 2012, 12:56 p.m., Torsten Grote wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107847/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 12:56 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This is a quick fix for bug #284274. It allows sending encrypted emails to recipients whose key is not fully trusted. This is done by passing alwaysTrust to Kleo::EncryptJob. I consider this save since there is a trust dialog warning about untrusted keys. In this request, I also made kmail to handle a denied trust dialog more gracefully.
> 
> 
> This addresses bug 284274.
>     http://bugs.kde.org/show_bug.cgi?id=284274
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.cpp b23ac65e11c07389c75121a44a354a27e2dc3e02 
>   messagecomposer/encryptjob.cpp 4e965e1480419869bb57bae07aae4a9a7c97299d 
> 
> Diff: http://git.reviewboard.kde.org/r/107847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten Grote
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/