[Kde-pim] Review Request: fixed 31 compiler warnings #1

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107961/#review24087
-----------------------------------------------------------



calendarsupport/incidencechanger.cpp
<http://git.reviewboard.kde.org/r/107961/#comment18363>

    No, SendResult is the correct type, what we want as a fix here is having an initial value:
    InvitationHandler::SendResult status = InvitationHandler::ResultNoSendingNeeded;



composereditor-ng/spellplugin/kspellplugin.cpp
<http://git.reviewboard.kde.org/r/107961/#comment18364>

    maybe keep that, it is a reminder that this method is not implemented properly



messagelist/core/modelinvariantrowmapper.cpp
<http://git.reviewboard.kde.org/r/107961/#comment18365>

    Remove the stray whitespace at the end of the line


- Kevin Krammer


On Dec. 27, 2012, 7:37 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107961/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 7:37 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8087209
> 
> 
> Diffs
> -----
> 
>   calendarsupport/incidencechanger.cpp dfb8a30 
>   composereditor-ng/composerview.cpp bcc5b53 
>   composereditor-ng/spellplugin/kspellplugin.cpp 7ba8e1b 
>   incidenceeditor-ng/editoritemmanager.cpp 281b91f 
>   incidenceeditor-ng/tests/modeltest.cpp 3aa8aa3 
>   kdgantt2/kdganttgraphicsitem.cpp d0bf7e4 
>   kdgantt2/kdganttlistviewrowcontroller.cpp e4b2f57 
>   libkleo/ui/keyselectiondialog.cpp 4af9a46 
>   libksieve/ksieveui/vacationdialog.cpp 3fbfeab 
>   messagelist/core/modelinvariantrowmapper.cpp a9820f6 
>   messagelist/core/view.cpp 221e17f 
>   messagelist/pane.cpp 3f8b324 
>   messageviewer/a11y/accessiblemailwebview.cpp 32b1035 
>   messageviewer/tests/util.cpp 37222dd 
> 
> Diff: http://git.reviewboard.kde.org/r/107961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/