[Kde-pim] Review Request: Fix for sending mails to untrusted recipients

Kevin Krammer krammer at kde.org
Sat Dec 22 12:25:10 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107847/#review23838
-----------------------------------------------------------



messagecomposer/composerviewbase.cpp
<http://git.reviewboard.kde.org/r/107847/#comment18207>

    style nitpick: looking further down I see else if on the same line as the if's closing bracket.


- Kevin Krammer


On Dec. 22, 2012, 12:15 p.m., Torsten Grote wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107847/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 12:15 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This is a quick fix for bug #284274. It allows sending encrypted emails to recipients whose key is not fully trusted. This is done by passing alwaysTrust to Kleo::EncryptJob. I consider this save since there is a trust dialog warning about untrusted keys. In this request, I also made kmail to handle a denied trust dialog more gracefully.
> 
> 
> This addresses bug 284274.
>     http://bugs.kde.org/show_bug.cgi?id=284274
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.cpp b23ac65e11c07389c75121a44a354a27e2dc3e02 
>   messagecomposer/encryptjob.cpp 4e965e1480419869bb57bae07aae4a9a7c97299d 
> 
> Diff: http://git.reviewboard.kde.org/r/107847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten Grote
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list