[Kde-pim] Review Request: Fix compiler warnings

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107812/#review23711
-----------------------------------------------------------



kmail/kmkernel.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18147>

    better keep those as unused warnings, this is not implemented yet and the warning will serve as a reminder



korganizer/views/todoview/incidencetreemodel.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18148>

    wrong intentation, should be aligned with Q_ASSERT



libkleo/ui/keyselectiondialog.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18149>

    maybe also keep as a reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18150>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18151>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18152>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18153>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18154>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18155>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18156>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18157>

    keep as reminder



mailimporter/filterinfogui.cpp
<http://git.reviewboard.kde.org/r/107812/#comment18158>

    keep as reminder


- Kevin Krammer


On Dec. 19, 2012, 4:05 a.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107812/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2012, 4:05 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This review request fixes 31 of the compiler warning produced when compiling KDE PIM. The fixes are mostly for unused variables/parameters, and are throughout the subprojects of KDE PIM.
> 
> 
> Diffs
> -----
> 
>   kleopatra/crypto/decryptverifyfilescontroller.cpp 3f0162d 
>   kleopatra/crypto/gui/resultpage.cpp 289272e 
>   kleopatra/dialogs/certificateselectiondialog.cpp 74a73e9 
>   kleopatra/utils/kdpipeiodevice.cpp c0da352 
>   kmail/collectionmailinglistpage.cpp b5f8f8b 
>   kmail/kmcomposewin.cpp d5ebd0e 
>   kmail/kmkernel.cpp 5a15f74 
>   korganizer/views/multiagendaview/multiagendaview.cpp 194b9d3 
>   korganizer/views/todoview/incidencetreemodel.cpp d80296f 
>   libkleo/ui/keyselectiondialog.cpp 4af9a46 
>   libkpgp/kpgpbase2.cpp 539397b 
>   mailcommon/filter/filterimporter/filterimporterbalsa.cpp c54a60f 
>   mailcommon/filter/filterimporter/filterimporterclawsmail.cpp 0be26b7 
>   mailcommon/filter/filterimporter/filterimporterprocmail.cpp 68be360 
>   mailcommon/folderselectiondialog.cpp 36e4ec6 
>   mailimporter/filterinfogui.cpp e7fb5b1 
>   messagecomposer/attachmentcontrollerbase.cpp 44749ce 
>   messageviewer/viewer_p.cpp 70477e4 
> 
> Diff: http://git.reviewboard.kde.org/r/107812/diff/
> 
> 
> Testing
> -------
> 
> After these changes, PIM still correctly builds
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/