[Kde-pim] Review Request: a more apropriated message for duplicated file-message

[Laurent Montel]

> On Dec. 13, 2012, 6:42 a.m., Laurent Montel wrote:
> > mailimporter/filter_kmail_maildir.cpp, line 183
> > <http://git.reviewboard.kde.org/r/107677/diff/1/?file=98647#file98647line183>
> >
> >     with ":" ?
> >     
> >     This changes in string is fixing a bug for you ? Because we can't change i18n for 4.10 if it's not fixing a bug :)
> 
> Kevin Krammer wrote:
>     If the error is that the message could not be imported because it is a duplicate of another, already imported one, then the following might be even better
>     "Could  not import %1, message is a duplicate" or "Could not import %1, duplicated message"

I prefere "Could not import %1, duplicated message"


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107677/#review23385
-----------------------------------------------------------


On Dec. 12, 2012, 2:15 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107677/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 2:15 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> If a file contains a duplicate, I propose a better message for the ErrorLog.
> 
> 
> Diffs
> -----
> 
>   mailimporter/filter_kmail_maildir.cpp bf55ded 
> 
> Diff: http://git.reviewboard.kde.org/r/107677/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/