[Kde-pim] Review Request: fixed 31 compiler warnings #2

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107978/#review24127
-----------------------------------------------------------


This reviewboard has been rushed through with hardly any time for people to look at it. Please revert the kalarm change, or suggest an actual fix instead of suppressing the warnings.


kalarm/alarmcalendar.cpp
<http://git.reviewboard.kde.org/r/107978/#comment18391>

    This is wrong. These warnings should remain until the error which they highlight is fixed.


- David Jarvie


On Dec. 28, 2012, 12:56 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107978/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 12:56 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8076213
> 
> 
> Diffs
> -----
> 
>   archivemailagent/archivemailkernel.cpp e32f510 
>   importwizard/abstractsettings.cpp 9037648 
>   importwizard/balsa/balsasettings.cpp 5f91913 
>   importwizard/opera/operasettings.cpp 90404c8 
>   importwizard/sylpheed/sylpheedsettings.cpp be25d66 
>   importwizard/thunderbird/addressbook/MorkParser.cpp d0acf97 
>   importwizard/trojita/trojitaaddressbook.cpp d368673 
>   incidenceeditor-ng/tests/modeltest.cpp 3aa8aa3 
>   kaddressbook/mainwidget.cpp a5865b5 
>   kalarm/alarmcalendar.cpp 26a5037 
>   kmailcvt/kmailcvtkernel.cpp 7077a62 
>   knotes/knoteslegacy.cpp 6471f32 
>   messagecomposer/autoimageresizing/autoimageresizedialog.cpp 9e2345a 
>   messagecomposer/tests/cryptofunctions.cpp 1e26a85 
>   pimsettingexporter/importcalendarjob.cpp 1456c60 
> 
> Diff: http://git.reviewboard.kde.org/r/107978/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/