[Kde-pim] Review Request: Kde PIM Api Library Documentation: report #1

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107991/#review24129
-----------------------------------------------------------



akonadi/calendar/calendarbase.h
<http://git.reviewboard.kde.org/r/107991/#comment18402>

    copy&paste mistake, parameter name is different here
    also not of the parent incidence but of the parent item



akonadi/calendar/calendarbase.h
<http://git.reviewboard.kde.org/r/107991/#comment18403>

    see above



akonadi/calendar/calendarbase.h
<http://git.reviewboard.kde.org/r/107991/#comment18404>

    the incidence to modify



akonadi/calendar/calendarclipboard.h
<http://git.reviewboard.kde.org/r/107991/#comment18405>

    to cut



akonadi/calendar/calendarclipboard.h
<http://git.reviewboard.kde.org/r/107991/#comment18406>

    @param mode how to treat child incidences. Defaults to #RecursiveMode



akonadi/calendar/calendarclipboard.h
<http://git.reviewboard.kde.org/r/107991/#comment18407>

    see above



akonadi/collection.h
<http://git.reviewboard.kde.org/r/107991/#comment18393>

    @param isVirtual virtual collection if @c true, otherwise a normal collection



akonadi/collectiondialog.h
<http://git.reviewboard.kde.org/r/107991/#comment18394>

    @param mimeTypes MIME type filter values



akonadi/collectiondialog.h
<http://git.reviewboard.kde.org/r/107991/#comment18395>

    @param rights access rights filter values



akonadi/collectiondialog.h
<http://git.reviewboard.kde.org/r/107991/#comment18396>

    @param text the dialog's description text 



akonadi/collectiondialog.h
<http://git.reviewboard.kde.org/r/107991/#comment18397>

    @param collection the dialog's pre-selected collection



akonadi/collectiondialog.h
<http://git.reviewboard.kde.org/r/107991/#comment18398>

    @param mode the selection mode to use



akonadi/collectionrequester.h
<http://git.reviewboard.kde.org/r/107991/#comment18399>

    @param rights the access rights filter values



akonadi/collectionsync_p.h
<http://git.reviewboard.kde.org/r/107991/#comment18400>

    typo in parameter name
    use @c true instead of TRUE (doxygen generates specialized markup for that)



akonadi/collectionsync_p.h
<http://git.reviewboard.kde.org/r/107991/#comment18401>

    @param hierachical @c true if collection remote IDs are relative to their parents' remote IDs



akonadi/contact/contacteditor.h
<http://git.reviewboard.kde.org/r/107991/#comment18408>

    the contact to use as template content



akonadi/contact/contactgroupeditor.h
<http://git.reviewboard.kde.org/r/107991/#comment18409>

    the group to use as template content



akonadi/contact/contactgroupsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18410>

    the query criterion to compare with
    



akonadi/contact/contactgroupsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18411>

    the value to match against



akonadi/contact/contactgroupsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18412>

    how to match the given value



akonadi/contact/contactgroupviewer.h
<http://git.reviewboard.kde.org/r/107991/#comment18413>

    the formatter to use



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18414>

    see above



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18415>

    see above



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18416>

    see above



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18417>

    see above



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18418>

    see above



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18419>

    keep this line as it was before (empty line with * at the beginning)



akonadi/contact/contactsearchjob.h
<http://git.reviewboard.kde.org/r/107991/#comment18420>

    the upper limit for number of search results



akonadi/kmime/addressattribute.h
<http://git.reviewboard.kde.org/r/107991/#comment18422>

    typo (capital B) in parameter name


- Kevin Krammer


On Dec. 28, 2012, 8:13 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107991/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 8:13 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Kde PIM Api Library Documentation: report #1
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/calendarbase.h 6b93f40 
>   akonadi/calendar/calendarclipboard.h 56a01ed 
>   akonadi/collection.h 4feb0a1 
>   akonadi/collectiondialog.h 0f2d4f9 
>   akonadi/collectionrequester.h 2607cb9 
>   akonadi/collectionsync_p.h 38a6a00 
>   akonadi/contact/contacteditor.h 0e2617f 
>   akonadi/contact/contacteditordialog.h 33ee0b2 
>   akonadi/contact/contactgroupeditor.h a189b53 
>   akonadi/contact/contactgroupsearchjob.h b4195b0 
>   akonadi/contact/contactgroupviewer.h 3cdfe64 
>   akonadi/contact/contactmetadata_p.h e3e895e 
>   akonadi/contact/contactsearchjob.h 7e8357e 
>   akonadi/contact/contactsfilterproxymodel.h 6069802 
>   akonadi/kmime/addressattribute.h c271211 
> 
> Diff: http://git.reviewboard.kde.org/r/107991/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/