[Kde-pim] Review Request: FIX LIBRARY API DOCUMENTATION #2

Sat Dec 29 12:43:25 GMT 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108000/#review24174
-----------------------------------------------------------


akonadi/calendar/etmcalendar.h
<http://git.reviewboard.kde.org/r/108000/#comment18530>

    hmm, I think this is the incidence's identifier
    @param uid the identifier for the incidence to check for rights


akonadi/calendar/etmcalendar.h
<http://git.reviewboard.kde.org/r/108000/#comment18531>

    the access right to check for


akonadi/calendar/invitationhandlerhelper_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18532>

    the action to set as default


akonadi/calendar/kcolumnfilterproxymodel_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18533>

    remove trailing whitespace


akonadi/entity.h
<http://git.reviewboard.kde.org/r/108000/#comment18500>

    let make that
    @param revision the entity's remote revision


akonadi/entitydisplayattribute.h
<http://git.reviewboard.kde.org/r/108000/#comment18502>

    @param name the icon name to use


akonadi/entitydisplayattribute.h
<http://git.reviewboard.kde.org/r/108000/#comment18501>

    @param color the background color to use


akonadi/entityrightsfiltermodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18503>

    @param rights the access rights filter values


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18504>

    @param show enabled displaying of hidden entities ...


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18505>

    like above, i.e. ... "enables displaying of..."


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18506>

    the name to display for the root collection


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18507>

    remove trailing whitespace


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18508>

    the model to query for the item


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18509>

    the item to look for


akonadi/entitytreemodel.h
<http://git.reviewboard.kde.org/r/108000/#comment18510>

    since this is a signal, fetching has already happend:
    @param collectionId the identifier of the fetched collection


akonadi/entitytreeview.h
<http://git.reviewboard.kde.org/r/108000/#comment18511>

    this is about the menu shown when you perform a drop (as in Drag&Drop) on the view, so it should be:
    drop action menu
    
    
akonadi/item.h
<http://git.reviewboard.kde.org/r/108000/#comment18512>

    @param size the size of the item in bytes


akonadi/item.h
<http://git.reviewboard.kde.org/r/108000/#comment18513>

    @param other the item to get values from


akonadi/itemserializer_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18514>

    @param item the item to apply to


akonadi/itemserializer_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18515>

    @param other the item to get values from


akonadi/itemserializer_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18516>

    @param item the item for which to list payload parts


akonadi/itemserializer_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18517>

    remove trailing whitespace


akonadi/itemserializerplugin.h
<http://git.reviewboard.kde.org/r/108000/#comment18518>

    @param item the item for which to list payload parts


akonadi/itemsync.h
<http://git.reviewboard.kde.org/r/108000/#comment18519>

    the transaction mode to use


akonadi/itemsync.h
<http://git.reviewboard.kde.org/r/108000/#comment18520>

    this is actually the other way around :)
    @param storedItem the item as it is now
    @param newItem the item as it should be


akonadi/job_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18521>

    the id of the item which has changed


akonadi/kcal/incidencemimetypevisitor.h
<http://git.reviewboard.kde.org/r/108000/#comment18534>

    the incidence to retrieve MIME type from


akonadi/preprocessorbase.h
<http://git.reviewboard.kde.org/r/108000/#comment18522>

    just
    @param result the processing result


akonadi/servermanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18523>

    lets say:
    the service type for which to return the D-Bus name


akonadi/servermanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18524>

    the agent type to use for D-Bus base name


akonadi/servermanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18525>

    the agent identifier to include in the D-Bus name


akonadi/servermanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18526>

    just:
    the string to adapt


akonadi/specialcollections_p.h
<http://git.reviewboard.kde.org/r/108000/#comment18527>

    the identifier of the resource for which to forget folders


akonadi/standardactionmanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18528>

    @param type the action to set a text for
    

akonadi/standardactionmanager.h
<http://git.reviewboard.kde.org/r/108000/#comment18529>

    @param text the text to display for the given action


- Kevin Krammer


On Dec. 29, 2012, 11:40 a.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108000/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 11:40 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
>  FIX LIBRARY API DOCUMENTATION #2
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/etmcalendar.h be3f669 
>   akonadi/calendar/invitationhandlerhelper_p.h 9d25e24 
>   akonadi/calendar/kcolumnfilterproxymodel_p.h c4e16ea 
>   akonadi/contact/contactviewer.h 14d9f48 
>   akonadi/contact/recentcontactscollections_p.h 046f5b9 
>   akonadi/entity.h e7d2477 
>   akonadi/entitydisplayattribute.h 2d33dd1 
>   akonadi/entitylistview.h a51d142 
>   akonadi/entitymimetypefiltermodel.h a9aee7d 
>   akonadi/entityrightsfiltermodel.h ff56ac4 
>   akonadi/entitytreemodel.h f7e5705 
>   akonadi/entitytreeview.h d2d7f21 
>   akonadi/item.h 7d1f931 
>   akonadi/itemmodifyjob.h fc5a3ed 
>   akonadi/itemserializer_p.h cc30eb4 
>   akonadi/itemserializerplugin.h 67b03c1 
>   akonadi/itemsync.h e761591 
>   akonadi/job_p.h 001a758 
>   akonadi/kcal/incidencemimetypevisitor.h a66ef42 
>   akonadi/kmime/specialmailcollections.h 1240339 
>   akonadi/monitor.h 24f51e8 
>   akonadi/monitor_p.h ca1623a 
>   akonadi/preprocessorbase.h fc2f8fc 
>   akonadi/recursivecollectionfilterproxymodel.h 3ecd32b 
>   akonadi/servermanager.h 18adbc7 
>   akonadi/session_p.h e0b9c59 
>   akonadi/specialcollections.h b0cb1ee 
>   akonadi/specialcollections_p.h 0c31538 
>   akonadi/standardactionmanager.h c3b70c2 
> 
> Diff: http://git.reviewboard.kde.org/r/108000/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/