[Kde-pim] Review Request: Make itemWithFlagsCount() correctly work with virtual collections

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107715/#review23528
-----------------------------------------------------------

Ship it!


Thanks!

- Volker Krause


On Dec. 14, 2012, 12:32 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107715/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 12:32 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> The SQL query in HandlerHelper::itemWithFlagsCount() is filtering the items by collectiondId which leads to incorrect results when the collection is virtual, because "SELECT FROM pimitemtable...WHERE pimitemtable.collectionId = virtualCollectionID" always returns 0 results. 
> 
> This fixes "Last Search" folder in KMail showing that all emails are unread.
> 
> 
> This addresses bugs 274936 and 305969.
>     http://bugs.kde.org/show_bug.cgi?id=274936
>     http://bugs.kde.org/show_bug.cgi?id=305969
> 
> 
> Diffs
> -----
> 
>   server/src/handlerhelper.cpp 16eef51 
> 
> Diff: http://git.reviewboard.kde.org/r/107715/diff/
> 
> 
> Testing
> -------
> 
> Created a new search in KMail with one unread message in results, the "Last Search" folder correctly displayed X messages in total, 1 unread.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/