[Kde-pim] Review Request: Load passwords async on startup, rather than sync

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107885/#review24078
-----------------------------------------------------------


I think we should ship this in 4.10 and master.  The code is fine, of course. 

- Allen Winter


On Dec. 23, 2012, 5:34 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107885/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 5:34 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Volker Krause and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Load passwords async on startup, rather than sync
> 
> (which was giving 4 nested event loops, with 4 transports, on kmail startup)
> This fixes the password dialog appearing when sending the first email.
> 
> BUG: 293271
> FIXED-IN: 4.10
> 
> 
> This addresses bug 293271.
>     http://bugs.kde.org/show_bug.cgi?id=293271
> 
> 
> Diffs
> -----
> 
>   mailtransport/transport.cpp 45bd69dcaa7e5730a366b4397eca6049049b9f75 
>   mailtransport/transportmanager.cpp 9bac654ef32e484ba5e168a92385033b85a3ecf6 
> 
> Diff: http://git.reviewboard.kde.org/r/107885/diff/
> 
> 
> Testing
> -------
> 
> Restarting maildispatcher and sending an email.
> Before: password dialog
> After: no dialog, the pass is taken from the wallet.
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/