[Kde-pim] Review Request: resolved 31 code checker issues

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107705/#review23425
-----------------------------------------------------------



resources/dav/common/davprincipalsearchjob.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18011>

    not really related, ain't it? ;)



resources/dav/common/davprincipalsearchjob.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18012>

    No, this needs to be applied to a type
    foreach ( const QPair<QString, QString> &fetchProperty, mFetchProperties )



resources/dav/common/davprincipalsearchjob.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18013>

    see above



resources/dav/resource/configdialog.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18014>

    see above



resources/dav/resource/configdialog.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18015>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18016>

    that doesn't look right. the old code had slot onHeadersReceived



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18017>

    doesn't look right either, the old code had onHeadersFetchDone
    I don't think this line need changing at all



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18018>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18019>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18020>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18021>

    see abiove



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18022>

    no, this is a false positive
    QByteArray::startsWith( const char* ) exists, so passing a string literal here is OK



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18023>

    same here



resources/microblog/idattribute.h
<http://git.reviewboard.kde.org/r/107705/#comment18024>

    not needed here, constructor does not take any argument



resources/mixedmaildir/mixedmaildirstore.cpp
<http://git.reviewboard.kde.org/r/107705/#comment18025>

    see above


- Kevin Krammer


On Dec. 13, 2012, 4:45 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107705/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 4:45 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8052202
> 
> 
> Diffs
> -----
> 
>   resources/dav/common/davprincipalsearchjob.cpp 9efc48a 
>   resources/dav/resource/configdialog.cpp 0354298 
>   resources/google/calendar/calendarresource.h eb0f29c 
>   resources/google/calendar/defaultreminderattribute.h 7eff614 
>   resources/google/contacts/contactsresource.h 224fc94 
>   resources/imap/retrieveitemstask.cpp 0b72e2a 
>   resources/maildir/libmaildir/maildir.cpp b6bb579 
>   resources/maildir/maildirresource.cpp df989c1 
>   resources/mbox/lockmethodpage.h 5ee879b 
>   resources/mbox/mboxresource.h 5b79f48 
>   resources/microblog/communication.h e62b978 
>   resources/microblog/configdialog.h beafe84 
>   resources/microblog/idattribute.h 29dd09d 
>   resources/microblog/microblog.h d3769b1 
>   resources/mixedmaildir/configdialog.h 340203c 
>   resources/mixedmaildir/kmindexreader/kmindexreader.h e611f9e 
>   resources/mixedmaildir/mixedmaildirresource.h 0e95456 
>   resources/mixedmaildir/mixedmaildirstore.cpp 99bf221 
>   resources/openxchange/openxchangeresource.h a466137 
>   resources/openxchange/oxa/usersrequestjob.h 2c6d72d 
>   resources/shared/dirsettingsdialog.h e998035 
> 
> Diff: http://git.reviewboard.kde.org/r/107705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/