[Kde-pim] Review Request: FIX LIBRARY API DOCUMENTATION Errors: Fix #3

Kevin Krammer krammer at kde.org
Mon Dec 31 10:11:03 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108038/#review24305
-----------------------------------------------------------


Just discard the changes in KCal/*, this modules if deprecated and succeeded by KCalCore.
You don't need to replace them with new changes, I should have added that to the task description


akonadi/calendar/standardcalendaractionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18631>

    @param selectionModel the selection model for collections



akonadi/calendar/standardcalendaractionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18632>

    @param selectionModel the selection model for items



akonadi/calendar/standardcalendaractionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18633>

    @param type the type of action to create



akonadi/contact/standardcontactactionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18634>

    @param selectionModel the selection model for collections



akonadi/contact/standardcontactactionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18635>

    this line looks wrong, probably copy&paste mistake



akonadi/contact/standardcontactactionmanager.h
<http://git.reviewboard.kde.org/r/108038/#comment18636>

    @param selectionModel the selection model for items



akonadi/transactionsequence.h
<http://git.reviewboard.kde.org/r/108038/#comment18630>

    @param job a job to ignore errors from



kabc/contactgroup.h
<http://git.reviewboard.kde.org/r/108038/#comment18637>

    @param uid identifier of the contact to reference



kabc/picture.h
<http://git.reviewboard.kde.org/r/108038/#comment18638>

    @param type the picture's data type



kimap/acl.h
<http://git.reviewboard.kde.org/r/108038/#comment18639>

    @param rights set of #Rights flags to normalize



kimap/acl.h
<http://git.reviewboard.kde.org/r/108038/#comment18640>

    @param rights set of #Rights flags to augment



kimap/imapset.h
<http://git.reviewboard.kde.org/r/108038/#comment18641>

    @param interval the interval to add



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18642>

    @param binddn the LDAP Bind DN to set



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18643>

    trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18645>

    to set



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18644>

    to set



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18646>

    to set



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18647>

    trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18648>

    trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18649>

    trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18650>

    trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108038/#comment18651>

    typo in parameter name (autho -> auth)


- Kevin Krammer


On Dec. 30, 2012, 8:10 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108038/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 8:10 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> FIX LIBRARY API DOCUMENTATION Errors: Fix #3 
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/standardcalendaractionmanager.h b1a45ba 
>   akonadi/contact/standardcontactactionmanager.h 45454ad 
>   akonadi/subscriptiondialog_p.h b59ce74 
>   akonadi/subscriptionmodel_p.h f1d146d 
>   akonadi/transactionsequence.h 5815377 
>   akonadi/trashrestorejob.h 0f0e03c 
>   kabc/contactgroup.h bfdb193 
>   kabc/picture.h b3b5a7f 
>   kalarmcal/alarmtext.h b20a745 
>   kcal/assignmentvisitor.h 37b6c27 
>   kcal/attachment.h 4ed8046 
>   kcal/calformat.h d252116 
>   kcal/comparisonvisitor.h 00673c7 
>   kcal/customproperties.h d06619e 
>   kcal/dndfactory.h 6068ff6 
>   kcal/incidenceformatter.h 3745fc7 
>   kcal/recurrence.h 75a09ba 
>   kcal/recurrencerule.h 2144b57 
>   kcal/resourcecached.h d1d6ef0 
>   kcal/resourcecalendar.h 008a5df 
>   kcal/resourcelocaldir.h 0123d4f 
>   kimap/acl.h c200d19 
>   kimap/getquotajob.h e332b36 
>   kimap/imapset.h a3417ac 
>   kldap/ldapconfigwidget.h d871410 
> 
> Diff: http://git.reviewboard.kde.org/r/108038/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list