[Kde-pim] Review Request: Fix knotes bug
Allen Winter
winter at kde.org
Fri Aug 17 00:37:35 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106051/#review17570
-----------------------------------------------------------
Ship it!
code looks ok. do you have commit access? If not, I will commit for you.
BTW, does this patch fix https://bugs.kde.org/show_bug.cgi?id=210507 "knotes font doesn't apply if rich text is turned off"
- Allen Winter
On Aug. 16, 2012, 10:42 a.m., Sergey Borovkov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106051/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2012, 10:42 a.m.)
>
>
> Review request for KDEPIM.
>
>
> Description
> -------
>
> Fixes bug in knotes.
> Steps to reproduce bug:
> 1. Open KNotes
> 2. Change default font for text in note
> 3. Type text. Close Knotes.
> 4. Open KNotes and look at the text on the previously created note. The text will be shown in other font.
> Also font is not remembered if user changes font and then selects all text, deletes it and start typing (default Knotes font is used then).
> This patch simply moves look and feel initialization after font etc. are set up and changes document() default font on note's font change.
>
>
> Diffs
> -----
>
> knotes/knote.cpp de59419
> knotes/knoteedit.cpp 10f7f7c
>
> Diff: http://git.reviewboard.kde.org/r/106051/diff/
>
>
> Testing
> -------
>
> ROSA Linux QA tested it and I used it myself
>
>
> Thanks,
>
> Sergey Borovkov
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list