[Kde-pim] Review Request: block error in the switch

Kevin Krammer krammer at kde.org
Tue Aug 21 08:53:21 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106099/#review17791
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Krammer


On Aug. 20, 2012, 1:08 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106099/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 1:08 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> The else statement at line 594 build a new block with the statement break.
> In this way, the case 'U' has no regular end for the other "if ( option ..."s,
> this doesn't generate an error because this is the last case in the switch,
> but anyway it is a block-error.
> 
> 
> Diffs
> -----
> 
>   kioslave/imap4/imapparser.cpp 5ba44b8 
> 
> Diff: http://git.reviewboard.kde.org/r/106099/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list