[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kblog

Kevin Krammer krammer at kde.org
Sat Aug 11 12:22:22 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105969/#review17235
-----------------------------------------------------------



kblog/blogger1.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13423>

    I would keep that as a single line condition



kblog/blogger1.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13424>

    same here



kblog/metaweblog.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13425>

    also keep as single line condition



kblog/metaweblog.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13426>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13429>

    space after this,



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13430>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13431>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13432>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13427>

    space after q, 



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13433>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13434>

    and again



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13435>

    also here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13436>

    keep this as a single line condition



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13437>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13438>

    same here



kblog/movabletype.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13439>

    {} around block



kblog/wordpressbuggy.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13440>

    space after this,



kblog/wordpressbuggy.cpp
<http://git.reviewboard.kde.org/r/105969/#comment13441>

    here as well


- Kevin Krammer


On Aug. 10, 2012, 4:06 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105969/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2012, 4:06 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   kblog/blog.cpp b073121 
>   kblog/blogger1.cpp 245bfed 
>   kblog/gdata.cpp 5e5a3b1 
>   kblog/metaweblog.cpp 2ba1d12 
>   kblog/movabletype.cpp a5143ab 
>   kblog/tests/testblogcomment.cpp 03943de 
>   kblog/tests/testblogger1.cpp b7d41b5 
>   kblog/tests/testblogmedia.cpp 3dcf8c2 
>   kblog/tests/testblogpost.cpp f79aa7b 
>   kblog/tests/testgdata.cpp 3d9d790 
>   kblog/tests/testlivejournal.cpp cece500 
>   kblog/tests/testmetaweblog.cpp 209faeb 
>   kblog/tests/testmovabletype.cpp a50e835 
>   kblog/tests/testwordpressbuggy.cpp 07d0054 
>   kblog/wordpressbuggy.cpp 340c2d8 
> 
> Diff: http://git.reviewboard.kde.org/r/105969/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list