[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kimap

[Kevin Krammer]

> On Aug. 26, 2012, 6:48 p.m., Kevin Krammer wrote:
> > kimap/idlejob.cpp, line 72
> > <http://git.reviewboard.kde.org/r/106077/diff/1/?file=78440#file78440line72>
> >
> >     spaces in i18nc()
> 
> Guy Maurel wrote:
>     we write about "not to yet change the function definition lines"
>     I could be done in the next step, global, not only here

yes, but this is not a function signature change but a function call (one call to function i18nc() and a call to IdleJobPrivate's constructor).
we fix those everywhere else so we should also fix them here


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106077/#review18039
-----------------------------------------------------------


On Aug. 27, 2012, 10:42 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106077/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 10:42 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   kimap/acl.h 40e738f 
>   kimap/acl.cpp 4d5a1f0 
>   kimap/acljobbase.h 39616a2 
>   kimap/acljobbase.cpp 2934348 
>   kimap/appendjob.h 9fdc2bd 
>   kimap/appendjob.cpp 7d8104c 
>   kimap/capabilitiesjob.h 0306f26 
>   kimap/capabilitiesjob.cpp c21938c 
>   kimap/closejob.h 3cadc72 
>   kimap/closejob.cpp 18abf79 
>   kimap/copyjob.h 5e75fdc 
>   kimap/copyjob.cpp de41458 
>   kimap/createjob.h daab478 
>   kimap/createjob.cpp 78f811f 
>   kimap/deleteacljob.h 0f06055 
>   kimap/deleteacljob.cpp ba7ec00 
>   kimap/deletejob.h 2876a90 
>   kimap/deletejob.cpp 883a43b 
>   kimap/expungejob.h 9862f59 
>   kimap/expungejob.cpp 355c179 
>   kimap/fetchjob.h aa31d2d 
>   kimap/fetchjob.cpp f820b70 
>   kimap/getacljob.h dd652d2 
>   kimap/getacljob.cpp 35313bb 
>   kimap/getmetadatajob.cpp 24592b7 
>   kimap/getquotajob.h 01231ea 
>   kimap/getquotajob.cpp a74ce98 
>   kimap/getquotarootjob.h b1fa49e 
>   kimap/getquotarootjob.cpp 9f7bae7 
>   kimap/idlejob.h 3a0917b 
>   kimap/idlejob.cpp 39489ee 
>   kimap/imapset.cpp 8588452 
>   kimap/imapstreamparser.cpp 50a8552 
>   kimap/job.h 4656049 
>   kimap/job.cpp b37e7d5 
>   kimap/listjob.h c90cea6 
>   kimap/listjob.cpp 01d9906 
>   kimap/listrightsjob.h ed4850d 
>   kimap/listrightsjob.cpp 93b1376 
>   kimap/loginjob.h 6064214 
>   kimap/loginjob.cpp 85407fb 
>   kimap/logoutjob.h e3f6553 
>   kimap/logoutjob.cpp b291f56 
>   kimap/message_p.h 9d703bf 
>   kimap/metadatajobbase.h f7ad6e2 
>   kimap/metadatajobbase.cpp 4eb900f 
>   kimap/myrightsjob.h 4e57d0e 
>   kimap/myrightsjob.cpp 49a69e1 
>   kimap/namespacejob.h 130c788 
>   kimap/namespacejob.cpp dd0c1a0 
>   kimap/quotajobbase.h 640ca0d 
>   kimap/quotajobbase.cpp 5398804 
>   kimap/renamejob.h 84ae96a 
>   kimap/renamejob.cpp 6334d10 
>   kimap/rfccodecs.cpp ae0141a 
>   kimap/searchjob.h 077e8d4 
>   kimap/searchjob.cpp 1a5e722 
>   kimap/selectjob.h c67d28c 
>   kimap/selectjob.cpp 7e1a24d 
>   kimap/session.h e23fbc4 
>   kimap/session.cpp 9344d8e 
>   kimap/sessionthread.cpp 2976c34 
>   kimap/setacljob.h 33df18d 
>   kimap/setacljob.cpp 409549d 
>   kimap/setmetadatajob.h 1391ecc 
>   kimap/setmetadatajob.cpp ac4ef02 
>   kimap/setquotajob.cpp 8ee27e7 
>   kimap/storejob.h 7c41d90 
>   kimap/storejob.cpp a6a2550 
>   kimap/subscribejob.h f0db503 
>   kimap/subscribejob.cpp be064ab 
>   kimap/tests/capabilitiesjobtest.cpp d4ad29d 
>   kimap/tests/createjobtest.cpp 09f50c7 
>   kimap/tests/deletejobtest.cpp 3c8ed46 
>   kimap/tests/fakeservertest.cpp 1399615 
>   kimap/tests/fetchjobtest.cpp 749234c 
>   kimap/tests/idlejobtest.cpp 0c35f49 
>   kimap/tests/kimaptest/fakeserver.cpp b6d3921 
>   kimap/tests/kimaptest/mockjob.h 99d5ac8 
>   kimap/tests/kimaptest/mockjob.cpp 33a7327 
>   kimap/tests/listjobtest.cpp 81fbfc4 
>   kimap/tests/loginjobtest.cpp a08ef9b 
>   kimap/tests/logoutjobtest.cpp 9028265 
>   kimap/tests/quotarootjobtest.cpp 5cf5a4f 
>   kimap/tests/renamejobtest.cpp a139a24 
>   kimap/tests/selectjobtest.cpp 9ee2a80 
>   kimap/tests/storejobtest.cpp fca7691 
>   kimap/tests/subscribejobtest.cpp f314345 
>   kimap/tests/testimapidle.cpp 48ec9e7 
>   kimap/tests/testimapserver.cpp 3ba8dbc 
>   kimap/tests/testrfccodecs.cpp fc27bbb 
>   kimap/tests/testsession.cpp ddb7465 
>   kimap/tests/unsubscribejobtest.cpp 1b4afe4 
>   kimap/unsubscribejob.h f03875e 
>   kimap/unsubscribejob.cpp 61678e8 
> 
> Diff: http://git.reviewboard.kde.org/r/106077/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/