[Kde-pim] Review Request: Make the incidence editor show recurrence exceptions formatted on disk as DATE-TIME values

Philipp Schmidt philschmidt at gmx.net
Mon Aug 6 10:26:39 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105889/#review16948
-----------------------------------------------------------


While browsing through the code I spotted some things that I missed, for example with this patch removing exceptions is broken as that relies on the row. I will try to fix that and then update the patch.

- Philipp Schmidt


On Aug. 6, 2012, 8:45 a.m., Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105889/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 8:45 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The normal calendar views recognize Exceptions formatted on disk as EXDATE with DATE-TIME format. However the list showing the recurrence exceptions does not. This Patch fixes that.
> 
> 
> This addresses bug 304652.
>     http://bugs.kde.org/show_bug.cgi?id=304652
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp 7e89f5b 
> 
> Diff: http://git.reviewboard.kde.org/r/105889/diff/
> 
> 
> Testing
> -------
> 
> Tested with local iCal calendar and remote ownCloud CalDAV instance. Shows exceptions in list created via Thunderbird and manually.
> 
> 
> Thanks,
> 
> Philipp Schmidt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list