[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kholidays
Kevin Krammer
krammer at kde.org
Tue Aug 14 17:09:26 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106016/#review17398
-----------------------------------------------------------
kholidays/tests/testholidayregion.cpp
<http://git.reviewboard.kde.org/r/106016/#comment13614>
I'd say keep region.regionCode on the same line as its "label" text, just like on the following lines
- Kevin Krammer
On Aug. 14, 2012, 4:01 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106016/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 4:01 p.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Krammer.
>
>
> Description
> -------
>
> same as kdepimlibs/akonadi
>
>
> Diffs
> -----
>
> kholidays/holidayregionselector.cpp 6e86553
> kholidays/parsers/plan1/holidayparserdriverplanold.cpp 063786e
> kholidays/parsers/plan2/holidayparserdriverplan.cpp 16f50f8
> kholidays/parsers/plan2/holidayscannerplan_p.h d38db47
> kholidays/tests/testholidayregion.cpp 08383c9
> kholidays/tests/testlunar.cpp 78192cc
> kholidays/zodiac.cpp ac0a4c3
>
> Diff: http://git.reviewboard.kde.org/r/106016/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list