[Kde-pim] Review Request: Summary: some more spaces, some less spaces, some more blocks, for kabc

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105879/#review16911
-----------------------------------------------------------


I've been only half way through, there seem to be many weird line breaks in conditions. maybe a faulty search/replace pattern


kabc/address.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13249>

    what is the reason for this change?



kabc/address.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13250>

    or here?



kabc/address.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13252>

    or here?



kabc/addressbook.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13253>

    why the newline?



kabc/addressbook.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13254>

    same here?



kabc/addressbook.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13255>

    same here?



kabc/addressbook.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13257>

    reason for this change?



kabc/addresseedialog.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13259>

    reason for the newline?



kabc/addresseedialog.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13260>

    same here?



kabc/addresseelist.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13261>

    the old code looks good to me. any specific reason for this change?



kabc/addresslineedit.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13262>

    same here



kabc/addresslineedit.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13263>

    old code looks good to me. do I miss something?



kabc/addresslineedit.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13265>

    same here



kabc/addresslineedit.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13266>

    same here



kabc/addresslineedit.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13268>

    looks also weird



kabc/contactgrouptool.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13269>

    also weird change



kabc/contactgrouptool.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13270>

    same here



kabc/distributionlist.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13271>

    very weird change



kabc/distributionlistdialog.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13272>

    reason here?



kabc/emailselectdialog.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13273>

    also weird



kabc/geo.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13274>

    see above



kabc/geo.cpp
<http://git.reviewboard.kde.org/r/105879/#comment13275>

    see above


- Kevin Krammer


On Aug. 5, 2012, 5:09 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105879/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2012, 5:09 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   kabc/address.cpp 112c59e 
>   kabc/addressbook.cpp 8b43a25 
>   kabc/addresseedialog.cpp a254c8e 
>   kabc/addresseehelper.cpp c422850 
>   kabc/addresseelist.cpp 1c3c107 
>   kabc/addresslineedit.cpp 16568b2 
>   kabc/contactgrouptool.cpp e63dfd0 
>   kabc/distributionlist.cpp b36368d 
>   kabc/distributionlistdialog.cpp fd3a027 
>   kabc/emailselectdialog.cpp f413365 
>   kabc/errorhandler.cpp eb92233 
>   kabc/formats/binaryformat.cpp e1fdf31 
>   kabc/geo.cpp 3b6ae16 
>   kabc/ldif.cpp 19addd9 
>   kabc/ldifconverter.cpp ea28614 
>   kabc/lock.cpp c7233c0 
>   kabc/locknull.cpp eff1aa5 
>   kabc/phonenumber.cpp 9a7d42f 
>   kabc/picture.cpp 0a51c8b 
>   kabc/plugins/dir/resourcedir.cpp 0635023 
>   kabc/plugins/dir/resourcedirconfig.cpp 5c7e556 
>   kabc/plugins/file/resourcefile.cpp 77a3511 
>   kabc/plugins/file/resourcefileconfig.cpp 90105d4 
>   kabc/plugins/ldapkio/resourceldapkio.cpp 8346a6a 
>   kabc/plugins/ldapkio/resourceldapkioconfig.cpp 729fe77 
>   kabc/plugins/net/resourcenetconfig.cpp fe0f0f5 
>   kabc/resource.cpp 5cc5204 
>   kabc/resourcecached.cpp 9a6f993 
>   kabc/scripts/addressee.src.h 90a858c 
>   kabc/scripts/addressee.src.cpp 85b7826 
>   kabc/scripts/field.src.cpp e1048fb 
>   kabc/sound.cpp fa65a06 
>   kabc/stdaddressbook.h fe2f69b 
>   kabc/stdaddressbook.cpp 31a9eef 
>   kabc/tests/addresstest.cpp 2567b9c 
>   kabc/tests/phonenumbertest.cpp b941b99 
>   kabc/tests/testaddresseelist.cpp 62c49d2 
>   kabc/tests/testkabc.cpp db17095 
>   kabc/tests/testkabcdlg.cpp f70089b 
>   kabc/timezone.cpp 45c95ac 
>   kabc/vcardconverter.cpp 7c1bc98 
>   kabc/vcardformat.cpp 321184f 
>   kabc/vcardparser/testread2.cpp f93e857 
>   kabc/vcardparser/testroundtrip.cpp e13945b 
>   kabc/vcardparser/testwrite.cpp f725bd2 
>   kabc/vcardparser/vcard.cpp d8bd13c 
>   kabc/vcardparser/vcardline.cpp 567ece6 
>   kabc/vcardparser/vcardparser.cpp 44c860e 
>   kabc/vcardtool.cpp ed32ba8 
> 
> Diff: http://git.reviewboard.kde.org/r/105879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/