[Kde-pim] Review Request: Store exceptions to recurring events as DATE-TIME values

[Philipp Schmidt]

> On Aug. 6, 2012, 7:48 p.m., Kevin Krammer wrote:
> > incidenceeditor-ng/incidencerecurrence.cpp, line 634
> > <http://git.reviewboard.kde.org/r/105889/diff/6/?file=76430#file76430line634>
> >
> >     sorry, me again :)
> >     I am not sure ++dtit is OK when dtit has just been erased.
> >     erase returns the iterator for the next element, so you could assign that to dtit and only do the ++dtit in the else case

The docs say that on erase() the iterator is moved to the next element. So took your solution.


- Philipp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105889/#review16997
-----------------------------------------------------------


On Aug. 6, 2012, 7:45 p.m., Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105889/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 7:45 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> As Bug 169336 describes, normal DATE values should only (optionally) be used to store exceptions to all-day events. This patch makes KOrganizer use DATE-TIME values, thus making it compatible to most other clients that only check for DATE-TIMEs. Existing VALUE=DATE exceptions are not touched, only newly created exceptions will be saved in this format.
> 
> Also fixes the bug that DATE-TIME formatted values were not shown in the exception list. It now shows DATE as well as DATE-TIME values.
> 
> 
> This addresses bugs 169336 and 304652.
>     http://bugs.kde.org/show_bug.cgi?id=169336
>     http://bugs.kde.org/show_bug.cgi?id=304652
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp 7e89f5b 
>   korganizer/calendarview.cpp 75c3307 
> 
> Diff: http://git.reviewboard.kde.org/r/105889/diff/
> 
> 
> Testing
> -------
> 
> Tested with local iCal calendar and remote ownCloud CalDAV instance adding exceptions in the instanceditor. Exceptions are neither shown on Android nor in the Calendar view. All Exceptions are shown in the exception list (also legacy DATE ones).
> 
> Adding Exceptions using the context menu in the calendar view also uses DATE-TIME now.
> 
> 
> Thanks,
> 
> Philipp Schmidt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/