[Kde-pim] Review Request: Enable auto completion in kmail composer even if nepomuk is disabled

Laurent Montel montel at kde.org
Wed Aug 1 10:25:49 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105810/#review16742
-----------------------------------------------------------


You don't make code in good class.
We must make it in libkdepim/addresseelineedit.cpp
And you use a sync method. I don't want it in completion code

- Laurent Montel


On Aug. 1, 2012, 7:49 a.m., Bellegarde Cédric wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105810/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 7:49 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch enable kmail composer auto completion when nepomuk has been disabled by user.
> 
> It's a really simple patch useful when you can't use nepomuk like on a laptop (powersaving).
> 
> 
> This addresses bug 304286.
>     http://bugs.kde.org/show_bug.cgi?id=304286
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerlineedit.cpp 059246e 
> 
> Diff: http://git.reviewboard.kde.org/r/105810/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bellegarde Cédric
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list