[Kde-pim] Review Request: Fix knotes bug

[laurent Montel]

Le vendredi 17 août 2012 14:01:34 Allen Winter a écrit :
> > On Aug. 16, 2012, 11:37 p.m., Allen Winter wrote:
> > > code looks ok.  do you have commit access?  If not, I will commit for
> > > you.
> > > BTW, does this patch fix https://bugs.kde.org/show_bug.cgi?id=210507
> > > "knotes font doesn't apply if rich text is turned off"> 
> > Sergey Borovkov wrote:
> >     Yes, I have developer account. Should I commit this to master only? Or
> >     to 4.9 branch also? I will check shortly whether this fixes that bug> 
> > Sergey Borovkov wrote:
> >     Yes, just checked it, looks like this patch fixes that problem
> 
> Nice.
> Please:
>  - commit to master and KDE/4.9 branches.

No please commit just in KDE/4.9

I will merge in master after so we can have some commit id in master/4.9
It's better.

Thanks

>  - resolve bug 21057
>  - close this review as submitted
> 
> Thanks so much, KNotes could use some love!
> 
> 
> - Allen
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106051/#review17570
> -----------------------------------------------------------
> 
> On Aug. 16, 2012, 10:42 a.m., Sergey Borovkov wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/106051/
> > -----------------------------------------------------------
> > 
> > (Updated Aug. 16, 2012, 10:42 a.m.)
> > 
> > 
> > Review request for KDEPIM.
> > 
> > 
> > Description
> > -------
> > 
> > Fixes bug in knotes.
> > Steps to reproduce bug:
> > 1. Open KNotes
> > 2. Change default font for text in note
> > 3. Type text. Close Knotes.
> > 4. Open KNotes and look at the text on the previously created note. The
> > text will be shown in other font. Also font is not remembered if user
> > changes font and then selects all text, deletes it and start typing
> > (default Knotes font is used then). This patch simply moves look and feel
> > initialization after font etc. are set up and changes document() default
> > font on note's font change.
> > 
> > 
> > Diffs
> > -----
> > 
> >   knotes/knote.cpp de59419
> >   knotes/knoteedit.cpp 10f7f7c
> > 
> > Diff: http://git.reviewboard.kde.org/r/106051/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > ROSA Linux QA tested it and I used it myself
> > 
> > 
> > Thanks,
> > 
> > Sergey Borovkov
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/
-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/