[Kde-pim] Review Request: Enable auto completion in kmail composer even if nepomuk is disabled

Laurent Montel montel at kde.org
Mon Aug 13 09:00:34 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105810/#review17293
-----------------------------------------------------------



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/105810/#comment13457>

    Perhaps you can make this test directly in
    akonadiPerformSearch
    
    => void ... ::akonadiPerformSearch(...)
    {
    if(!Nepomuk2::resourcemanager::instance()->initalized()) {
       akonadiPerformDbSearh();
        return;
      }
      ....
    }
    
    => it avoids to add this check in all code


- Laurent Montel


On Aug. 11, 2012, 3:08 p.m., Bellegarde Cédric wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105810/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2012, 3:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch enable kmail composer auto completion when nepomuk has been disabled by user.
> 
> It's a really simple patch useful when you can't use nepomuk like on a laptop (powersaving).
> 
> 
> This addresses bug 304286.
>     http://bugs.kde.org/show_bug.cgi?id=304286
> 
> 
> Diffs
> -----
> 
>   libkdepim/addresseelineedit.h 3fd1f69 
>   libkdepim/addresseelineedit.cpp 614e4eb 
> 
> Diff: http://git.reviewboard.kde.org/r/105810/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bellegarde Cédric
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list