[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kldap
Kevin Krammer
krammer at kde.org
Sun Aug 26 20:57:10 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106161/#review18052
-----------------------------------------------------------
kldap/ber.cpp
<http://git.reviewboard.kde.org/r/106161/#comment14293>
I don't think it makes change to change those C casts that way. We don't have that anywhere else I think.
The only improvement would be a switch to static_cast<>
- Kevin Krammer
On Aug. 24, 2012, 2:12 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106161/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2012, 2:12 p.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Krammer.
>
>
> Description
> -------
>
> same as kdepimlibs/akonadi
>
>
> Diffs
> -----
>
> kldap/ber.cpp 8ebd597
> kldap/ldapconfigwidget.cpp 2bd1b59
> kldap/ldapconnection.cpp 269e236
> kldap/ldapdefs.h 0412f0f
> kldap/ldapmodelnode_p.cpp 8490a99
> kldap/ldapobject.cpp 6ff24ed
> kldap/ldapoperation.cpp 6c9b2bf
> kldap/ldapserver.h c7a43c3
> kldap/ldapurl.cpp d8e4349
>
> Diff: http://git.reviewboard.kde.org/r/106161/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list