[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kioslave, part 1

Guy Maurel guy-kde at maurel.de
Sun Aug 19 16:35:37 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106079/
-----------------------------------------------------------

(Updated Aug. 19, 2012, 3:35 p.m.)


Review request for KDEPIM-Libraries and Kevin Krammer.


Changes
-------

I found some more "," without space.
Whats about lines
1224:     infoMessage( imapNamespaces.join( "," ) );
and
2367:       if ( !_uid.contains( ':' ) && !_uid.contains( ',' ) && !_uid.contains( '*' )

What is right? ',' or ","


Description
-------

same as kdepimlibs/akonadi


Diffs (updated)
-----

  kioslave/common.h 4845c97 
  kioslave/imap4/imap4.h fff4173 
  kioslave/imap4/imap4.cpp 9b33d71 

Diff: http://git.reviewboard.kde.org/r/106079/diff/


Testing
-------


Thanks,

Guy Maurel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list