[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kioslave, part 1
Kevin Krammer
krammer at kde.org
Sun Aug 19 13:41:58 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106079/#review17695
-----------------------------------------------------------
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13837>
No, this is inside a string
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13838>
same here
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13839>
else on line with } of the if block
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13840>
{} around block
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13859>
space between comma and tmp
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13860>
space between comma and myUser
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13861>
intendation fo mailboxName should be below !item
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13862>
space between comma and tmp
kioslave/imap4/imap4.cpp
<http://git.reviewboard.kde.org/r/106079/#comment13863>
space between comma and tmp
- Kevin Krammer
On Aug. 18, 2012, 4:50 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106079/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2012, 4:50 p.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Krammer.
>
>
> Description
> -------
>
> same as kdepimlibs/akonadi
>
>
> Diffs
> -----
>
> kioslave/common.h 4845c97
> kioslave/imap4/imap4.h fff4173
> kioslave/imap4/imap4.cpp 9b33d71
>
> Diff: http://git.reviewboard.kde.org/r/106079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list