[Kde-pim] Review Request: Fix hang when ktimetracker quits after creating kpart failed

[Sergio Luis Martins]

> On May 13, 2012, 10:05 a.m., Kevin Krammer wrote:
> > Looks good to me.
> > However I am wondering if a better way of exiting would be to do a kFatal() logging.
> > 
> > Thorsten, any preference?
> 
> Allen Winter wrote:
>     Sergio, you fixed the hang in a completely different way already right?
>     I don't think this patch should be needed any longer?
>     
>     Please let Lasse know if we should cancel this review.

What I fixed was KTimeTracker's "Could not create the KTimeTracker part." bug.
After that bug happened, an empty dialog appeared ( which is what this patch is trying to fix ).

Feel free to commit this, although it won't happen again, as the kpart is properly created now.


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104929/#review13768
-----------------------------------------------------------


On May 13, 2012, 2:56 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104929/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 2:56 a.m.)
> 
> 
> Review request for KDEPIM and Thorsten Staerk.
> 
> 
> Description
> -------
> 
> KTimeTracker hanged after displaying either "Could not create the KTimeTracker part."  or "Could not find the KTimeTracker part." and never quit. This fixes it.
> 
> 
> Diffs
> -----
> 
>   ktimetracker/mainwindow.cpp abb3747 
> 
> Diff: http://git.reviewboard.kde.org/r/104929/diff/
> 
> 
> Testing
> -------
> 
> Compiled and checked it doesn't hang anymore.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/