[Kde-pim] KPeople in playground

[David Edmundson]

Ok, review time.

NepomukTpChannelDelegate::NepomukTpChannelDelegate
you don't need use 90% of the factories added.

NepomukTpChannelDelegate::~NepomukTpChannelDelegate()
d_ptr is leaked

NepomukTpChannelDelegate::startChat

Crash if account path isn't correct
Crash if that account isn't online
(possible) Crash if that account is online but contactmanager isn't ready


NepomukTpChannelDelegate::finished(Tp::PendingOperation *op)

This channel hint is no longer correct
Crash if passed contact ID wasn't valid

PersonContactModelItem
    void addData(const QUrl &key, const QString &value);
Why is all data strings?

PersonsModel

I don't understand the model structure here, you have a different row
for Email, IM, phone, Mobile Phone, Postal.
Could you explain it to me.
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/