[Kde-pim] Review Request: Use a more portable ps(1) call in the clamav script.

Allen Winter winter at kde.org
Tue Aug 21 23:26:58 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106111/#review17825
-----------------------------------------------------------

Ship it!


looks good. please put in 4.9 and master

- Allen Winter


On Aug. 21, 2012, 12:46 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106111/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 12:46 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Use a more portable ps(1) call in the clamav script.
> 
> -e means all processes are selected on Linux's ps, while on the BSDs
> and OS X it means the environment should be printed along with the
> commands.
> 
> Replacing -e with -a -x should work on all platforms according to the
> Linux, OS X, FreeBSD, OpenBSD and NetBSD man pages.
> 
> 
> Diffs
> -----
> 
>   kmail/avscripts/kmail_clamav.sh b6227b39fbed5924e628daf27f7d551c629591ab 
> 
> Diff: http://git.reviewboard.kde.org/r/106111/diff/
> 
> 
> Testing
> -------
> 
> I don't use this script myself, but the same change has been used on the FreeBSD packages for a couple of years.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list