[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kimap
Kevin Krammer
krammer at kde.org
Sun Aug 26 19:48:01 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106077/#review18039
-----------------------------------------------------------
kimap/acl.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14251>
space between <<=and 1
kimap/appendjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14252>
spaces around +
kimap/appendjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14253>
space between parameters and += operator and round +operator
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14254>
spaces around + operator
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14255>
spaces around + operator
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14256>
same here
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14257>
spaces around first = operator
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14258>
spaces around - operator
kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14259>
spaces around + operator
kimap/getmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14260>
space between - and 1
kimap/getmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14261>
same here
kimap/getmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14262>
same here
kimap/getmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14263>
same here
kimap/getmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14264>
same here
kimap/idlejob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14265>
spaces in i18nc()
kimap/idlejob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14266>
spaces around >= operators
kimap/idlejob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14267>
spaces around >= operator
kimap/idlejob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14268>
same here
kimap/job.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14269>
spaces in d_ptr(), JobPrivate() and i18n()
kimap/job.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14270>
spaces in d_ptr()
kimap/loginjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14271>
spaces in LoginJobPrivate and i18n
kimap/loginjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14272>
spaces in sasl_client_start()
kimap/message_p.h
<http://git.reviewboard.kde.org/r/106077/#comment14273>
spaces around + operator
kimap/selectjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14274>
spaces around + operator
kimap/selectjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14275>
spaces in toLongLong()
kimap/selectjob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14276>
spaces in toInt()
kimap/session.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14277>
spaces around != operator
kimap/session.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14278>
spaces around + operators
kimap/session.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14279>
space between payload and += operator
kimap/session.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14280>
spaces around + operator
kimap/sessionthread.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14281>
spaces in calls to member constructors
kimap/sessionthread.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14282>
space between literal and += operator
kimap/sessionthread.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14283>
spaces around > operator
kimap/setmetadatajob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14284>
space after += operator
kimap/storejob.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14285>
spaces in StoreJobPrivate and i18n
kimap/tests/fetchjobtest.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14286>
spaces around > operator
kimap/tests/fetchjobtest.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14287>
Spaces in FetchJob()
kimap/tests/idlejobtest.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14288>
spaces in Q_DECLARE_METATYPE
kimap/tests/kimaptest/fakeserver.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14292>
spaces around != operator
kimap/tests/quotarootjobtest.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14289>
const QByteArray &root
kimap/tests/testimapserver.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14290>
space after comma
kimap/tests/testimapserver.cpp
<http://git.reviewboard.kde.org/r/106077/#comment14291>
spaces around + operators
- Kevin Krammer
On Aug. 18, 2012, 2:01 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106077/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2012, 2:01 p.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Krammer.
>
>
> Description
> -------
>
> same as kdepimlibs/akonadi
>
>
> Diffs
> -----
>
> kimap/acl.h 40e738f
> kimap/acl.cpp 4d5a1f0
> kimap/acljobbase.h 39616a2
> kimap/acljobbase.cpp 2934348
> kimap/appendjob.h 9fdc2bd
> kimap/appendjob.cpp 7d8104c
> kimap/capabilitiesjob.h 0306f26
> kimap/capabilitiesjob.cpp c21938c
> kimap/closejob.h 3cadc72
> kimap/closejob.cpp 18abf79
> kimap/copyjob.h 5e75fdc
> kimap/copyjob.cpp de41458
> kimap/createjob.h daab478
> kimap/createjob.cpp 78f811f
> kimap/deleteacljob.h 0f06055
> kimap/deleteacljob.cpp ba7ec00
> kimap/deletejob.h 2876a90
> kimap/deletejob.cpp 883a43b
> kimap/expungejob.h 9862f59
> kimap/expungejob.cpp 355c179
> kimap/fetchjob.h aa31d2d
> kimap/fetchjob.cpp f820b70
> kimap/getacljob.h dd652d2
> kimap/getacljob.cpp 35313bb
> kimap/getmetadatajob.cpp 24592b7
> kimap/getquotajob.h 01231ea
> kimap/getquotajob.cpp a74ce98
> kimap/getquotarootjob.h b1fa49e
> kimap/getquotarootjob.cpp 9f7bae7
> kimap/idlejob.h 3a0917b
> kimap/idlejob.cpp 39489ee
> kimap/imapset.cpp 8588452
> kimap/imapstreamparser.cpp 50a8552
> kimap/job.h 4656049
> kimap/job.cpp b37e7d5
> kimap/listjob.h c90cea6
> kimap/listjob.cpp 01d9906
> kimap/listrightsjob.h ed4850d
> kimap/listrightsjob.cpp 93b1376
> kimap/loginjob.h 6064214
> kimap/loginjob.cpp 85407fb
> kimap/logoutjob.h e3f6553
> kimap/logoutjob.cpp b291f56
> kimap/message_p.h 9d703bf
> kimap/metadatajobbase.h f7ad6e2
> kimap/metadatajobbase.cpp 4eb900f
> kimap/myrightsjob.h 4e57d0e
> kimap/myrightsjob.cpp 49a69e1
> kimap/namespacejob.h 130c788
> kimap/namespacejob.cpp dd0c1a0
> kimap/quotajobbase.h 640ca0d
> kimap/quotajobbase.cpp 5398804
> kimap/renamejob.h 84ae96a
> kimap/renamejob.cpp 6334d10
> kimap/rfccodecs.cpp ae0141a
> kimap/searchjob.h 077e8d4
> kimap/searchjob.cpp 1a5e722
> kimap/selectjob.h c67d28c
> kimap/selectjob.cpp 7e1a24d
> kimap/session.h e23fbc4
> kimap/session.cpp 9344d8e
> kimap/sessionthread.cpp 2976c34
> kimap/setacljob.h 33df18d
> kimap/setacljob.cpp 409549d
> kimap/setmetadatajob.h 1391ecc
> kimap/setmetadatajob.cpp ac4ef02
> kimap/setquotajob.cpp 8ee27e7
> kimap/storejob.h 7c41d90
> kimap/storejob.cpp a6a2550
> kimap/subscribejob.h f0db503
> kimap/subscribejob.cpp be064ab
> kimap/tests/capabilitiesjobtest.cpp d4ad29d
> kimap/tests/createjobtest.cpp 09f50c7
> kimap/tests/deletejobtest.cpp 3c8ed46
> kimap/tests/fakeservertest.cpp 1399615
> kimap/tests/fetchjobtest.cpp 749234c
> kimap/tests/idlejobtest.cpp 0c35f49
> kimap/tests/kimaptest/fakeserver.cpp b6d3921
> kimap/tests/kimaptest/mockjob.h 99d5ac8
> kimap/tests/kimaptest/mockjob.cpp 33a7327
> kimap/tests/listjobtest.cpp 81fbfc4
> kimap/tests/loginjobtest.cpp a08ef9b
> kimap/tests/logoutjobtest.cpp 9028265
> kimap/tests/quotarootjobtest.cpp 5cf5a4f
> kimap/tests/renamejobtest.cpp a139a24
> kimap/tests/selectjobtest.cpp 9ee2a80
> kimap/tests/storejobtest.cpp fca7691
> kimap/tests/subscribejobtest.cpp f314345
> kimap/tests/testimapidle.cpp 48ec9e7
> kimap/tests/testimapserver.cpp 3ba8dbc
> kimap/tests/testrfccodecs.cpp fc27bbb
> kimap/tests/testsession.cpp ddb7465
> kimap/tests/unsubscribejobtest.cpp 1b4afe4
> kimap/unsubscribejob.h f03875e
> kimap/unsubscribejob.cpp 61678e8
>
> Diff: http://git.reviewboard.kde.org/r/106077/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list