[Kde-pim] Review Request: Store exceptions to recurring events as DATE-TIME values

[Philipp Schmidt]

> On Aug. 8, 2012, 12:45 a.m., Sergio Luis Martins wrote:
> > There's some time zone problem.
> > I added an all day event, recurring daily, starting at 5th of August.
> > I added an exception at 6th of August.
> > The editor says it added an exception at 5th of August.
> > 
> > The ical file says:
> > EXDATE:20120805T230000Z
> > 
> > It's now 01h30 in Portugal (GMT+1), 00h30 GMT.
> > 
> > 
> >

Ses, I can reproduce it here. Seems to me due to the fact that All Day events are still saved as VALUE=DATE (which makes sense since they are supposed to be all day in any timezone) there is no associated time, so the exception apparently just takes a wrong one. So for all day events I will save exceptions as before, meaning I will have to add a conversion if an all-Day event is converted to one with a specified time and vice versa.


- Philipp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105889/#review17089
-----------------------------------------------------------


On Aug. 6, 2012, 8:05 p.m., Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105889/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 8:05 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> As Bug 169336 describes, normal DATE values should only (optionally) be used to store exceptions to all-day events. This patch makes KOrganizer use DATE-TIME values, thus making it compatible to most other clients that only check for DATE-TIMEs. Existing VALUE=DATE exceptions are not touched, only newly created exceptions will be saved in this format.
> 
> Also fixes the bug that DATE-TIME formatted values were not shown in the exception list. It now shows DATE as well as DATE-TIME values.
> 
> 
> This addresses bugs 169336 and 304652.
>     http://bugs.kde.org/show_bug.cgi?id=169336
>     http://bugs.kde.org/show_bug.cgi?id=304652
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp 7e89f5b 
>   korganizer/calendarview.cpp 75c3307 
> 
> Diff: http://git.reviewboard.kde.org/r/105889/diff/
> 
> 
> Testing
> -------
> 
> Tested with local iCal calendar and remote ownCloud CalDAV instance adding exceptions in the instanceditor. Exceptions are neither shown on Android nor in the Calendar view. All Exceptions are shown in the exception list (also legacy DATE ones).
> 
> Adding Exceptions using the context menu in the calendar view also uses DATE-TIME now.
> 
> 
> Thanks,
> 
> Philipp Schmidt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/