[Kde-pim] Review Request: Fix hang when ktimetracker quits after creating kpart failed

[Thorsten Staerk]

Allen, Sergio,

I know you have been working a lot here, thanks for this. I am 
distracted these months and I am glad things can move along without me. 
Soon I will be back in the fun :)
Go ahead, I have no preference but to keep ktimetracker lean. Sergio, 
will you come to the next Osnabrueck meeting?

thanks

Thorsten

On 2012-08-18 00:18, Allen Winter wrote:
>> On May 13, 2012, 10:05 a.m., Kevin Krammer wrote:
>> > Looks good to me.
>> > However I am wondering if a better way of exiting would be to do a 
>> kFatal() logging.
>> >
>> > Thorsten, any preference?
>
> Sergio, you fixed the hang in a completely different way already 
> right?
> I don't think this patch should be needed any longer?
>
> Please let Lasse know if we should cancel this review.
>
>
> - Allen
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104929/#review13768
> -----------------------------------------------------------
>
>
> On May 13, 2012, 2:56 a.m., Lasse Liehu wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/104929/
>> -----------------------------------------------------------
>>
>> (Updated May 13, 2012, 2:56 a.m.)
>>
>>
>> Review request for KDEPIM and Thorsten Staerk.
>>
>>
>> Description
>> -------
>>
>> KTimeTracker hanged after displaying either "Could not create the 
>> KTimeTracker part."  or "Could not find the KTimeTracker part." and 
>> never quit. This fixes it.
>>
>>
>> Diffs
>> -----
>>
>>   ktimetracker/mainwindow.cpp abb3747
>>
>> Diff: http://git.reviewboard.kde.org/r/104929/diff/
>>
>>
>> Testing
>> -------
>>
>> Compiled and checked it doesn't hang anymore.
>>
>>
>> Thanks,
>>
>> Lasse Liehu
>>
>>
>
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/