[Kde-pim] Review Request: Store exceptions to recurring events as DATE-TIME values

[Sergio Luis Martins]

> On Aug. 14, 2012, 12:55 p.m., Commit Hook wrote:
> > This review has been submitted with commit d0cf55390afd41fc0b9264fcba93334004bd6994 by Jekyll Wu to branch KDE/4.9.
> 
> Jekyll Wu wrote:
>     Sorry, I filled the wrong number in the commit hook. I intended to close review 105989.
> 
> Philipp Schmidt wrote:
>     Yes, I am a little surprised that this would be committed without further comments from sergio or a working fix for the "change to all day and back" problem.

The fix in KCalCore should be a separate review, because it's in a different repo. Then we can commit both at the same time.


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105889/#review17376
-----------------------------------------------------------


On Aug. 13, 2012, 4:44 p.m., Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105889/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 4:44 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> As Bug 169336 describes, normal DATE values should only (optionally) be used to store exceptions to all-day events. This patch makes KOrganizer use DATE-TIME values, thus making it compatible to most other clients that only check for DATE-TIMEs. Existing VALUE=DATE exceptions are not touched, only newly created exceptions will be saved in this format.
> 
> Also fixes the bug that DATE-TIME formatted values were not shown in the exception list. It now shows DATE as well as DATE-TIME values.
> 
> 
> This addresses bugs 169336 and 304652.
>     http://bugs.kde.org/show_bug.cgi?id=169336
>     http://bugs.kde.org/show_bug.cgi?id=304652
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp 7e89f5b 
>   korganizer/calendarview.cpp 75c3307 
> 
> Diff: http://git.reviewboard.kde.org/r/105889/diff/
> 
> 
> Testing
> -------
> 
> Tested with local iCal calendar and remote ownCloud CalDAV instance adding exceptions in the instanceditor. Exceptions are neither shown on Android nor in the Calendar view. All Exceptions are shown in the exception list (also legacy DATE ones).
> 
> Adding Exceptions using the context menu in the calendar view also uses DATE-TIME now.
> 
> 
> Thanks,
> 
> Philipp Schmidt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/