[Kde-pim] Review Request: kmail: now it is allowed to create a new folder on the top of an imap folder

Kevin Ottens ervin at kde.org
Thu Sep 22 18:30:53 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102031/#review6733
-----------------------------------------------------------



resources/imap/addcollectiontask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment5941>

    We can't assume the separator will always be '/' at the top level, it's likely to be wrong on some servers.
    
    If the NAMESPACES extension is supported we can sense it from the empty namespace. If not, I'm not sure how to reliably detect it... one would have to dive in the RFC I think.


- Kevin


On Sept. 20, 2011, 3:37 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102031/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 3:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> On kmail 2, if you try to add a folder under your top imap folder, you will see that the button "Add folder" is disable. This patch is fixing this issue.
> 
> 
> This addresses bug 251704.
>     http://bugs.kde.org/show_bug.cgi?id=251704
> 
> 
> Diffs
> -----
> 
>   resources/imap/addcollectiontask.h de83683 
>   resources/imap/addcollectiontask.cpp 81c7dd9 
>   resources/imap/retrievecollectionstask.cpp e86a2ba 
> 
> Diff: http://git.reviewboard.kde.org/r/102031/diff
> 
> 
> Testing
> -------
> 
> Kdepim and kdepim-runtime compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list