[Kde-pim] Review Request: making kmail network-aware

[Martin Bednar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/
-----------------------------------------------------------

(Updated Sept. 11, 2011, 8:41 p.m.)


Review request for KDEPIM.


Changes
-------

Now Caching the result of Solid::Networking::status() (you were right Sergio, each call generates a dbus roundtrip)
Moved all network detecting logic into KMKernel.cpp (seemed more logical with the caching, and because most checks based on it were made there)
On line 1002, askToGoOnline checks if the user has decided that Kmail is offline : if ( GlobalSettings::self()->networkState() == GlobalSettings::EnumNetworkState::Offline ), because calling isOffline() returns true if the network status is Disconnecting or Unconnected, prompting the user to go online (maybe on multiple occasions) even though kmail can not do anything about it.


Summary
-------

Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.


Diffs (updated)
-----

  kmail/kmkernel.h 6d49a15 
  kmail/kmkernel.cpp a4f2481 
  kmail/kmmainwidget.h eed2a6a 
  kmail/kmmainwidget.cpp 7509713 

Diff: http://git.reviewboard.kde.org/r/102431/diff


Testing
-------

compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/