[Kde-pim] Review Request: Some MeeGo KCalCore fixed

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102730/#review6932
-----------------------------------------------------------

Ship it!


looks good.  i'll apply locally and run our unit tests.  if the tests pass, then I will commit for you.
thanks Alvaro.


- Allen Winter


On Sept. 29, 2011, 7:27 a.m., Álvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102730/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 7:27 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> A long overdue set of fixes that we have done in our kcalcore version.
> 
> Most of them are small leaks here and there, members not initialized, etc.
> 
> I cannot commit them, so if you agree, could you push them?
> 
> 
> Diffs
> -----
> 
>   kcalcore/icalformat.cpp 468bec1 
>   kcalcore/icaltimezones.cpp c8e379c 
>   kcalcore/memorycalendar.cpp 97365e1 
>   kcalcore/recurrence.cpp 6effb9a 
> 
> Diff: http://git.reviewboard.kde.org/r/102730/diff/diff
> 
> 
> Testing
> -------
> 
> On MeeGo, but not directly on KDE.
> 
> 
> Thanks,
> 
> Álvaro Manera
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/