[Kde-pim] Review Request: kmail can use KStatusNotifierItem's standard system tray Quit action

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102514/#review6278
-----------------------------------------------------------


This review has been submitted with commit 7dbe154261f8316e8b2d40756c022be077a10ed4 by Jonathan Marten to branch master.

- Commit


On Sept. 1, 2011, 7:30 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102514/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 7:30 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> KMail uses KStatusNotifierItem to show its icon in the system tray, if configured to do so.  This has a predefined action for "Quit", which asks the user for confirmation before quitting the application.  To be consistent with other applications (e.g. Akregator), KMail should use this action too.
> 
> This patch finds the KSNI's "Quit" action and uses that into the system tray popup menu, instead of the main widget's action.
> 
> 
> Diffs
> -----
> 
>   kmail/kmsystemtray.cpp e879631 
> 
> Diff: http://git.reviewboard.kde.org/r/102514/diff
> 
> 
> Testing
> -------
> 
> Built KMail with these changes, tested possible ways of quitting:
> 
> Close main window => stay in system tray or exit KMail, depending on configuration.
> Close main window with another composer or viewer window open => just close main window.
> 
> System tray menu - Quit, dialogue "Confirm Quit From System Tray" appears.
> Click "OK" in that => KMail closes all open windows and quits.
> Click "Cancel" in that => KMail does not quit.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/