[Kde-pim] Review Request: Providing accessible information in message list

Volker Krause vkrause at kde.org
Sun Sep 4 09:10:07 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102430/#review6260
-----------------------------------------------------------


Again, I can't comment on the a11y feature itself, but code looks sane and free of side-effects for the non-a11y case, so IMHO this can go in.

- Volker


On Aug. 25, 2011, 7:28 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102430/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 7:28 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> This patch modifies MessageList::Core::Model::data to handle Qt::AccessibleTextRole as role.
> 
> A new method called accessibleTextForField has been added to MessageItem, this method returns an QString representation of the message entry in the message list.
> 
> 
> Diffs
> -----
> 
>   messagelist/core/messageitem.h 154646b 
>   messagelist/core/messageitem.cpp 015985f 
>   messagelist/core/model.cpp 0447542 
> 
> Diff: http://git.reviewboard.kde.org/r/102430/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Email list in accerciser
>   http://git.reviewboard.kde.org/r/102430/s/240/
> 
> 
> Thanks,
> 
> José
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list