[Kde-pim] Review Request: Enable contact filtering by email address availabillity

[Martin Bednar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102619/
-----------------------------------------------------------

(Updated Sept. 20, 2011, 11:17 p.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Created an enum as suggested. Not sure if converting the enum to int in setFilterFlags(int) is correct.


Summary
-------

Adds an option to ContactsFilterProxyModel to filter out contacts with no email addresses. This is useful in the EmailAddressSelectionWidget which, as its name suggests, should only show contacts with email addresses.


This addresses bug 250242.
    http://bugs.kde.org/show_bug.cgi?id=250242


Diffs (updated)
-----

  akonadi/contact/contactsfilterproxymodel.h 416869b 
  akonadi/contact/contactsfilterproxymodel.cpp eecc220 
  akonadi/contact/emailaddressselectionwidget.cpp fc7ec44 

Diff: http://git.reviewboard.kde.org/r/102619/diff


Testing
-------

created contacts with and without email addresses. As expected, those without didn't appear in the messagecomposer address selection widget.


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/